On Wed, Mar 24, 2010 at 11:46:23AM +, Daniel P. Berrange wrote:
This defines the wire format for the new virDomainUpdateDeviceFlags()
API, and implements the server client side of the marshalling code.
* daemon/remote.c: Server side dispatch for virDomainUpdateDeviceFlags
*
On Mon, Mar 22, 2010 at 02:28:51PM -0600, Eric Blake wrote:
On 03/22/2010 01:05 PM, Daniel P. Berrange wrote:
+if (virDomainUpdateDeviceFlags (dom, args-xml, args-flags) == -1) {
+virDomainFree(dom);
Inconsistency in whether there is a space before ( in function calls.
Which
This defines the wire format for the new virDomainUpdateDeviceFlags()
API, and implements the server client side of the marshalling code.
* daemon/remote.c: Server side dispatch for virDomainUpdateDeviceFlags
* src/remote/remote_driver.c: Client side serialization for
On 03/22/2010 01:05 PM, Daniel P. Berrange wrote:
+if (virDomainUpdateDeviceFlags (dom, args-xml, args-flags) == -1) {
+virDomainFree(dom);
Inconsistency in whether there is a space before ( in function calls.
Which style is intended, or are both permitted?
Otherwise, ACK.
--