Re: [libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

2013-01-07 Thread Osier Yang
On 2013年01月04日 22:30, Eric Blake wrote: On 01/03/2013 08:35 PM, Osier Yang wrote: ...when you could just use a single int value comprising the combination of major and minor as the hash key, if only you had used Sounds good, how about something like "805516", where "8" is major, and "16" is t

Re: [libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

2013-01-04 Thread Eric Blake
On 01/03/2013 08:35 PM, Osier Yang wrote: >> ...when you could just use a single int value comprising the combination >> of major and minor as the hash key, if only you had used > > Sounds good, how about something like "805516", where "8" is major, and > "16" is the minor? It should be small eno

Re: [libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

2013-01-03 Thread Osier Yang
On 2013年01月04日 04:02, Eric Blake wrote: On 01/02/2013 07:37 AM, Osier Yang wrote: This introduces a hash table for qemu driver, to store the shared disk's info as (@major:minor, @ref_count). @ref_count is the number of domains which shares the disk. Since we only care about if the disk support

Re: [libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

2013-01-03 Thread Eric Blake
On 01/02/2013 07:37 AM, Osier Yang wrote: > This introduces a hash table for qemu driver, to store the shared > disk's info as (@major:minor, @ref_count). @ref_count is the number > of domains which shares the disk. > > Since we only care about if the disk support unprivileged SG_IO > commands, an

[libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

2013-01-02 Thread Osier Yang
This introduces a hash table for qemu driver, to store the shared disk's info as (@major:minor, @ref_count). @ref_count is the number of domains which shares the disk. Since we only care about if the disk support unprivileged SG_IO commands, and the SG_IO commands only make sense for block disk, t

[libvirt] [PATCH 2/6] qemu: Add a hash table for the shared disks

2012-12-18 Thread Osier Yang
This introduces a hash table for qemu driver, to store the shared disk's info as (@major:minor, @ref_count). @ref_count is the number of domains which shares the disk. Since we only care about if the disk support unprivileged SG_IO commands, and the SG_IO commands only make sense for block disk, t