subject:"\[libvirt\] \[PATCH 2\/6\] virNetDevMacVLanTapOpen\: Slightly rework"

Re: [libvirt] [PATCH 2/6] virNetDevMacVLanTapOpen: Slightly rework

2015-12-07 Thread Michal Privoznik

On 04.12.2015 17:02, Laine Stump wrote: > On 12/04/2015 07:30 AM, Michal Privoznik wrote: >> There are few outdated things. Firstly, we don't need to undergo >> the torture of fopen, fscanf and fclose when we have nice wrapper >> over that: virFileReadAll. Secondly, we can use dynamically >>

Re: [libvirt] [PATCH 2/6] virNetDevMacVLanTapOpen: Slightly rework

2015-12-04 Thread Laine Stump

On 12/04/2015 07:30 AM, Michal Privoznik wrote: There are few outdated things. Firstly, we don't need to undergo the torture of fopen, fscanf and fclose when we have nice wrapper over that: virFileReadAll. Secondly, we can use dynamically allocated buffer for the interface index. Nothing

[libvirt] [PATCH 2/6] virNetDevMacVLanTapOpen: Slightly rework

2015-12-04 Thread Michal Privoznik

There are few outdated things. Firstly, we don't need to undergo the torture of fopen, fscanf and fclose when we have nice wrapper over that: virFileReadAll. Secondly, we can use dynamically allocated buffer for the interface index. Signed-off-by: Michal Privoznik ---