Re: [libvirt] [PATCH 2/7] Add accessors for logging filters and outputs

2009-10-08 Thread Daniel Veillard
On Wed, Oct 07, 2009 at 03:34:38PM -0400, Amy Griffis wrote: Daniel P. Berrange wrote: [Tue Oct 06 2009, 05:00:55AM EDT] Having looked at the wway the next patch uses these, I think it'd be nicer to change the contract to just be extern char *virLogGetFilters(void);

Re: [libvirt] [PATCH 2/7] Add accessors for logging filters and outputs

2009-10-07 Thread Amy Griffis
Daniel P. Berrange wrote: [Tue Oct 06 2009, 05:00:55AM EDT] Having looked at the wway the next patch uses these, I think it'd be nicer to change the contract to just be extern char *virLogGetFilters(void); extern char *virLogGetOutputs(void); Heh, that's how I wrote it

Re: [libvirt] [PATCH 2/7] Add accessors for logging filters and outputs

2009-10-07 Thread Daniel P. Berrange
On Wed, Oct 07, 2009 at 03:34:38PM -0400, Amy Griffis wrote: Daniel P. Berrange wrote: [Tue Oct 06 2009, 05:00:55AM EDT] Having looked at the wway the next patch uses these, I think it'd be nicer to change the contract to just be extern char *virLogGetFilters(void);

Re: [libvirt] [PATCH 2/7] Add accessors for logging filters and outputs

2009-10-05 Thread Daniel P. Berrange
On Sun, Oct 04, 2009 at 03:28:46PM -0400, Amy Griffis wrote: When configuring logging settings, keep more information about the output destination. Add accessors to retrieve the filter and output settings in the original string form; this to be used to set up environment for a child process

Re: [libvirt] [PATCH 2/7] Add accessors for logging filters and outputs

2009-10-05 Thread Amy Griffis
Daniel P. Berrange wrote: [Mon Oct 05 2009, 08:51:00AM EDT] On Sun, Oct 04, 2009 at 03:28:46PM -0400, Amy Griffis wrote: When configuring logging settings, keep more information about the output destination. Add accessors to retrieve the filter and output settings in the original string

[libvirt] [PATCH 2/7] Add accessors for logging filters and outputs

2009-10-04 Thread Amy Griffis
When configuring logging settings, keep more information about the output destination. Add accessors to retrieve the filter and output settings in the original string form; this to be used to set up environment for a child process that also logs. Open output files O_APPEND so child can also write