Re: [libvirt] [PATCH 2/7] Support callbacks on virStream APIs in remote driver client

2010-08-20 Thread Daniel P. Berrange
On Thu, Aug 19, 2010 at 02:14:58PM -0600, Eric Blake wrote: On 08/17/2010 11:02 AM, Daniel P. Berrange wrote: The current remote driver code for streams only supports blocking I/O mode. This is fine for the usage with migration but is a problem for more general use cases, in particular

Re: [libvirt] [PATCH 2/7] Support callbacks on virStream APIs in remote driver client

2010-08-20 Thread Eric Blake
On 08/20/2010 03:07 AM, Daniel P. Berrange wrote: +privst-cbDispatch = 1; +remoteDriverUnlock(priv); +(cb)(st, VIR_STREAM_EVENT_READABLE, cbOpaque); Do we have/want a return value from this callback? If so, what would we do about a non-zero return value? You could

Re: [libvirt] [PATCH 2/7] Support callbacks on virStream APIs in remote driver client

2010-08-19 Thread Eric Blake
On 08/17/2010 11:02 AM, Daniel P. Berrange wrote: The current remote driver code for streams only supports blocking I/O mode. This is fine for the usage with migration but is a problem for more general use cases, in particular bi-directional streams. This adds supported for the stream

[libvirt] [PATCH 2/7] Support callbacks on virStream APIs in remote driver client

2010-08-17 Thread Daniel P. Berrange
The current remote driver code for streams only supports blocking I/O mode. This is fine for the usage with migration but is a problem for more general use cases, in particular bi-directional streams. This adds supported for the stream callbacks and non-blocking I/O. with the minor caveat is that