Re: [libvirt] [PATCH 2/7] tests: qemuxml2xml: Remove testing with allowed format detection

2018-03-06 Thread Peter Krempa
On Tue, Mar 06, 2018 at 08:49:35 -0500, John Ferlan wrote: > > > On 03/02/2018 11:56 AM, Peter Krempa wrote: > > Nobody should use format detection due to security implications. > > While I cannot disagree technically - would it be "useful" from a code > coverage viewpoint to have just "one" do

Re: [libvirt] [PATCH 2/7] tests: qemuxml2xml: Remove testing with allowed format detection

2018-03-06 Thread John Ferlan
On 03/02/2018 11:56 AM, Peter Krempa wrote: > Nobody should use format detection due to security implications. While I cannot disagree technically - would it be "useful" from a code coverage viewpoint to have just "one" do the allowDiskFormatProbing assignment similar to how various *TLS

[libvirt] [PATCH 2/7] tests: qemuxml2xml: Remove testing with allowed format detection

2018-03-02 Thread Peter Krempa
Nobody should use format detection due to security implications. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/disk-drive-detect-zeroes.xml| 2 +- tests/qemuxml2argvdata/hugepages-memaccess.xml | 1 +