Re: [libvirt] [PATCH 2/9] qemuDomain{Attach, Remove}NetDevice: Prefer qemuDomainSupportsNetdev

2016-09-22 Thread John Ferlan
On 08/16/2016 11:41 AM, Michal Privoznik wrote: > Depending on domain OS type, and interface address type we might > not want to use -netdev even though qemu has the capability. We > should use more advanced check implemented in > qemuDomainSupportsNetdev() function. > > Signed-off-by: Michal Pr

Re: [libvirt] [PATCH 2/9] qemuDomain{Attach, Remove}NetDevice: Prefer qemuDomainSupportsNetdev

2016-08-29 Thread Michal Privoznik
On 29.08.2016 06:52, Laine Stump wrote: > On 08/16/2016 11:41 AM, Michal Privoznik wrote: >> Depending on domain OS type, and interface address type we might >> not want to use -netdev even though qemu has the capability. We >> should use more advanced check implemented in >> qemuDomainSupportsNetd

Re: [libvirt] [PATCH 2/9] qemuDomain{Attach, Remove}NetDevice: Prefer qemuDomainSupportsNetdev

2016-08-28 Thread Laine Stump
On 08/16/2016 11:41 AM, Michal Privoznik wrote: Depending on domain OS type, and interface address type we might not want to use -netdev even though qemu has the capability. We should use more advanced check implemented in qemuDomainSupportsNetdev() function. So the effect of using qemuDomainSu

[libvirt] [PATCH 2/9] qemuDomain{Attach, Remove}NetDevice: Prefer qemuDomainSupportsNetdev

2016-08-16 Thread Michal Privoznik
Depending on domain OS type, and interface address type we might not want to use -netdev even though qemu has the capability. We should use more advanced check implemented in qemuDomainSupportsNetdev() function. Signed-off-by: Michal Privoznik --- src/qemu/qemu_hotplug.c | 12 ++-- 1 fil