Re: [libvirt] [PATCH 2/9] s/long long/size_t/ for file line numbers in logging code

2012-09-28 Thread Daniel P. Berrange
On Thu, Sep 27, 2012 at 01:05:55PM -0600, Eric Blake wrote: On 09/27/2012 10:44 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The __LINE__ macro value is specified to fit in the size_t Not quite accurate. C99 merely says: 6.10.4 p3: ... a line number as

[libvirt] [PATCH 2/9] s/long long/size_t/ for file line numbers in logging code

2012-09-27 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The __LINE__ macro value is specified to fit in the size_t type, so use that instead of 'long long' in the logging code Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/logging.c | 14 +++--- src/util/logging.h | 6 +++---

Re: [libvirt] [PATCH 2/9] s/long long/size_t/ for file line numbers in logging code

2012-09-27 Thread Eric Blake
On 09/27/2012 10:44 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The __LINE__ macro value is specified to fit in the size_t Not quite accurate. C99 merely says: 6.10.4 p3: ... a line number as specified by the digit sequence (interpreted as a decimal integer).