Re: [libvirt] [PATCH 20/41] secret: introduce virtsecretd daemon

2019-07-28 Thread Andrea Bolognani
On Sun, 2019-07-28 at 17:22 +0200, Andrea Bolognani wrote: > Anyway, with the caveat that the comments made for previous patches > are addressed here as well if they apply, > > Reviewed-by: Andrea Bolognani Patches 21-31 are basically the same as this one, so they also get a R-b with the same

Re: [libvirt] [PATCH 20/41] secret: introduce virtsecretd daemon

2019-07-28 Thread Andrea Bolognani
On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: [...] > +++ b/src/secret/virtsecretd.service.in [...] > +[Install] > +WantedBy=multi-user.target > +Also=virtsecretd.socket > +Also=virtsecretd-ro.socket > +Also=virtsecretd-admin.socket Interestingly, we *do* include the admin socket

[libvirt] [PATCH 20/41] secret: introduce virtsecretd daemon

2019-07-23 Thread Daniel P . Berrangé
The virtsecretd daemon will be responsible for providing the secret API driver functionality. The secret driver is still loaded by the main libvirtd daemon at this stage, so virtsecretd must not be running at the same time. Signed-off-by: Daniel P. Berrangé --- .gitignore