Re: [libvirt] [PATCH 21/34] Convert character devices over to use -device

2010-01-15 Thread Daniel P. Berrange
On Wed, Jan 13, 2010 at 03:56:03PM +0100, Paolo Bonzini wrote: > On 01/08/2010 06:23 PM, Daniel P. Berrange wrote: > >diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > >index 5dcd50f..eded887 100644 > >--- a/src/qemu/qemu_conf.c > >+++ b/src/qemu/qemu_conf.c > >@@ -1592,6 +1592,9 @@ static

Re: [libvirt] [PATCH 21/34] Convert character devices over to use -device

2010-01-15 Thread Daniel Veillard
On Fri, Jan 08, 2010 at 05:23:17PM +, Daniel P. Berrange wrote: > The current character device syntax uses either > > -serial tty,path=/dev/ttyS2 > > Or > > -chardev tty,id=serial0,path=/dev/ttyS2 -serial chardev:serial0 > > With the new -device support, we now prefer > > -chardev fi

Re: [libvirt] [PATCH 21/34] Convert character devices over to use -device

2010-01-13 Thread Paolo Bonzini
On 01/08/2010 06:23 PM, Daniel P. Berrange wrote: diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 5dcd50f..eded887 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1592,6 +1592,9 @@ static char *qemuDiskDriveName(const virDomainDiskDefPtr disk) case VIR_D

[libvirt] [PATCH 21/34] Convert character devices over to use -device

2010-01-08 Thread Daniel P. Berrange
The current character device syntax uses either -serial tty,path=/dev/ttyS2 Or -chardev tty,id=serial0,path=/dev/ttyS2 -serial chardev:serial0 With the new -device support, we now prefer -chardev file,id=serial0,path=/tmp/serial.log -device isa-serial,chardev=serial0 This patch changes