Re: [libvirt] [PATCH 25/28] conf: support host-side IP/route information in

2016-06-24 Thread John Ferlan
On 06/24/2016 11:19 AM, Laine Stump wrote: > On 06/24/2016 09:48 AM, John Ferlan wrote: >> [...] >>> +virDomainNetDefValidate(const virDomainNetDef *net) >>> +{ >>> +if ((net->hostIP.nroutes || net->hostIP.nips) && >>> +net->type != VIR_DOMAIN_NET_TYPE_ETHERNET) { >>> +

Re: [libvirt] [PATCH 25/28] conf: support host-side IP/route information in

2016-06-24 Thread Laine Stump
On 06/24/2016 09:48 AM, John Ferlan wrote: On 06/22/2016 01:37 PM, Laine Stump wrote: This is non-intuitively placed as a sub-element of , because it will be used to configure the interface that is named in (which is the interface on the host-side). (The already-existing configuration for the

Re: [libvirt] [PATCH 25/28] conf: support host-side IP/route information in

2016-06-24 Thread John Ferlan
On 06/22/2016 01:37 PM, Laine Stump wrote: > This is non-intuitively placed as a sub-element of , because > it will be used to configure the interface that is named in dev='x'/> (which is the interface on the host-side). (The > already-existing configuration for the guest-side of interfaces is

[libvirt] [PATCH 25/28] conf: support host-side IP/route information in

2016-06-22 Thread Laine Stump
This is non-intuitively placed as a sub-element of , because it will be used to configure the interface that is named in (which is the interface on the host-side). (The already-existing configuration for the guest-side of interfaces is in subelements directly under ):