Re: [libvirt] [PATCH 3/3] qemu: agent: take monitor lock in qemuAgentNotifyEvent

2016-12-11 Thread Nikolay Shirokovskiy
On 09.12.2016 17:42, John Ferlan wrote: > > > On 12/09/2016 03:55 AM, Nikolay Shirokovskiy wrote: >> >> >> On 08.12.2016 19:40, John Ferlan wrote: >>> >>> >>> On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote: qemuAgentNotifyEvent notify on a lock condition without taking the lock. T

Re: [libvirt] [PATCH 3/3] qemu: agent: take monitor lock in qemuAgentNotifyEvent

2016-12-09 Thread John Ferlan
On 12/09/2016 03:55 AM, Nikolay Shirokovskiy wrote: > > > On 08.12.2016 19:40, John Ferlan wrote: >> >> >> On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote: >>> qemuAgentNotifyEvent notify on a lock condition without taking >>> the lock. This works but it is a subject to race conditions. >>>

Re: [libvirt] [PATCH 3/3] qemu: agent: take monitor lock in qemuAgentNotifyEvent

2016-12-09 Thread Nikolay Shirokovskiy
On 08.12.2016 19:40, John Ferlan wrote: > > > On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote: >> qemuAgentNotifyEvent notify on a lock condition without taking >> the lock. This works but it is a subject to race conditions. >> --- >> src/qemu/qemu_agent.c | 4 >> 1 file changed, 4 ins

Re: [libvirt] [PATCH 3/3] qemu: agent: take monitor lock in qemuAgentNotifyEvent

2016-12-08 Thread John Ferlan
On 11/24/2016 04:19 AM, Nikolay Shirokovskiy wrote: > qemuAgentNotifyEvent notify on a lock condition without taking > the lock. This works but it is a subject to race conditions. > --- > src/qemu/qemu_agent.c | 4 > 1 file changed, 4 insertions(+) > But the vm is locked prior to any priv

[libvirt] [PATCH 3/3] qemu: agent: take monitor lock in qemuAgentNotifyEvent

2016-11-24 Thread Nikolay Shirokovskiy
qemuAgentNotifyEvent notify on a lock condition without taking the lock. This works but it is a subject to race conditions. --- src/qemu/qemu_agent.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 5230cbc..ad031d0 100644 --- a/src/qemu/q