Re: [libvirt] [PATCH 3/3] qemuBuildCommandLine: Change the condition for -nographics

2016-02-23 Thread Ján Tomko
On Tue, Feb 23, 2016 at 09:49:09AM +0100, Michal Privoznik wrote: > There's this check when building command line that whenever > domain has no graphics card configured we put -nographics onto > qemu command line. The check is 'if (!def->graphics)'. This > makes coverity think that def->graphics

[libvirt] [PATCH 3/3] qemuBuildCommandLine: Change the condition for -nographics

2016-02-23 Thread Michal Privoznik
There's this check when building command line that whenever domain has no graphics card configured we put -nographics onto qemu command line. The check is 'if (!def->graphics)'. This makes coverity think that def->graphics can be NULL, which is true. But later in the code every access to