Re: [libvirt] [PATCH 3/3] virBuffer: Try harder to free buffer

2019-05-06 Thread Erik Skultety
On Fri, May 03, 2019 at 11:18:09AM +0200, Michal Privoznik wrote: > On 5/3/19 11:01 AM, Erik Skultety wrote: > > On Thu, Apr 18, 2019 at 02:11:25PM +0200, Michal Privoznik wrote: > > > Currently, the way virBufferFreeAndReset() works is it relies on > > > virBufferContentAndReset() to fetch the buf

Re: [libvirt] [PATCH 3/3] virBuffer: Try harder to free buffer

2019-05-03 Thread Michal Privoznik
On 5/3/19 11:01 AM, Erik Skultety wrote: On Thu, Apr 18, 2019 at 02:11:25PM +0200, Michal Privoznik wrote: Currently, the way virBufferFreeAndReset() works is it relies on virBufferContentAndReset() to fetch the buffer content which is then freed. This works as long as there is no bug in virBuff

Re: [libvirt] [PATCH 3/3] virBuffer: Try harder to free buffer

2019-05-03 Thread Erik Skultety
On Thu, Apr 18, 2019 at 02:11:25PM +0200, Michal Privoznik wrote: > Currently, the way virBufferFreeAndReset() works is it relies on > virBufferContentAndReset() to fetch the buffer content which is > then freed. This works as long as there is no bug in virBuffer* > implementation (not true apparen

[libvirt] [PATCH 3/3] virBuffer: Try harder to free buffer

2019-04-18 Thread Michal Privoznik
Currently, the way virBufferFreeAndReset() works is it relies on virBufferContentAndReset() to fetch the buffer content which is then freed. This works as long as there is no bug in virBuffer* implementation (not true apparently). Explicitly call free() over buffer content. Signed-off-by: Michal P