Re: [libvirt] [PATCH 3/3] virNetDevMacVLanCreateWithVPortProfile: Drop @ret

2016-08-10 Thread Ján Tomko
On Tue, Aug 09, 2016 at 07:32:45PM +0200, Michal Privoznik wrote: Usually, this variable is used to hold the return value for a function of ours. Well, this is not the case. Its use does not match our pattern and therefore it is very misleading. Drop it and define an alternative @rc variable, but

[libvirt] [PATCH 3/3] virNetDevMacVLanCreateWithVPortProfile: Drop @ret

2016-08-09 Thread Michal Privoznik
Usually, this variable is used to hold the return value for a function of ours. Well, this is not the case. Its use does not match our pattern and therefore it is very misleading. Drop it and define an alternative @rc variable, but only in that single block where it is needed. Signed-off-by: Micha