Re: [libvirt] [PATCH 3/4] chardev: Add function to output -chardev options

2009-11-04 Thread Richard W.M. Jones
On Tue, Nov 03, 2009 at 04:07:40PM +, Matthew Booth wrote: Note that, on its own, this patch will generate a warning about an unused static function. +/* This function outputs a -chardev command line option which describes only the + * host side of the character device */ +static int

Re: [libvirt] [PATCH 3/4] chardev: Add function to output -chardev options

2009-11-04 Thread Matthew Booth
Agree virBuffer is nicer here, although it's not used anywhere else in qemu_conf.c. Here's an updated patch which uses a virBuffer instead. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 3/4] chardev: Add function to output -chardev options

2009-11-02 Thread Matthew Booth
Note that, on its own, this patch will generate a warning about an unused static function. --- src/qemu/qemu_conf.c | 87 ++ 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index