Re: [libvirt] [PATCH 3/4] conf: Fix XML ctxt swap in virDomainNetDefParseXML

2019-02-22 Thread Ján Tomko
On Wed, Feb 20, 2019 at 09:46:58AM -0500, John Ferlan wrote: Alter the logic to return @tmpnode to ctxt->node in both the error and non-error path when calling virDomainNetIPInfoParseXML. What is the motivation here? On error, ctxt->node will be restored anyway to 'oldnode'. Jano

Re: [libvirt] [PATCH 3/4] conf: Fix XML ctxt swap in virDomainNetDefParseXML

2019-02-20 Thread John Ferlan
On 2/20/19 10:42 AM, Ján Tomko wrote: > On Wed, Feb 20, 2019 at 09:46:58AM -0500, John Ferlan wrote: >> Alter the logic to return @tmpnode to ctxt->node in both the error >> and non-error path when calling virDomainNetIPInfoParseXML. >> > > What is the motivation here? > > On error,

[libvirt] [PATCH 3/4] conf: Fix XML ctxt swap in virDomainNetDefParseXML

2019-02-20 Thread John Ferlan
Alter the logic to return @tmpnode to ctxt->node in both the error and non-error path when calling virDomainNetIPInfoParseXML. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c