Re: [libvirt] [PATCH 3/4] network: log error for unknown virNetworkUpdate command codes

2012-09-21 Thread Laine Stump
On 09/21/2012 04:13 PM, Peter Krempa wrote: > On 09/21/12 21:46, Laine Stump wrote: >> Every level of the code for virNetworkUpdate was assuming that some >> other level was checking for validity of the "command" arg, but none >> actually were. The result was that an invalid command code would do >

Re: [libvirt] [PATCH 3/4] network: log error for unknown virNetworkUpdate command codes

2012-09-21 Thread Peter Krempa
On 09/21/12 21:46, Laine Stump wrote: Every level of the code for virNetworkUpdate was assuming that some other level was checking for validity of the "command" arg, but none actually were. The result was that an invalid command code would do nothing, but also report success. Since the command c

[libvirt] [PATCH 3/4] network: log error for unknown virNetworkUpdate command codes

2012-09-21 Thread Laine Stump
Every level of the code for virNetworkUpdate was assuming that some other level was checking for validity of the "command" arg, but none actually were. The result was that an invalid command code would do nothing, but also report success. Since the command code isn't used until the very lowest lev