Re: [libvirt] [PATCH 3/4] qemu: Enforce ACPI, UEFI requirements

2017-03-29 Thread John Ferlan
On 03/29/2017 10:12 AM, Andrea Bolognani wrote: > On Mon, 2017-03-27 at 08:03 -0400, John Ferlan wrote: >>> @@ -6252,9 +6252,23 @@ qemuBuildPMCommandLine(virCommandPtr cmd, >>> virCommandAddArg(cmd, "-no-shutdown"); >>> } >>> >>> +/* Architectures that support ACPI also

Re: [libvirt] [PATCH 3/4] qemu: Enforce ACPI, UEFI requirements

2017-03-29 Thread Andrea Bolognani
On Mon, 2017-03-27 at 08:03 -0400, John Ferlan wrote: > > @@ -6252,9 +6252,23 @@ qemuBuildPMCommandLine(virCommandPtr cmd, > >  virCommandAddArg(cmd, "-no-shutdown"); > >  } > >   > > +/* Architectures that support ACPI also support -no-acpi as a way > > + * of turning it off,

Re: [libvirt] [PATCH 3/4] qemu: Enforce ACPI, UEFI requirements

2017-03-27 Thread John Ferlan
On 03/09/2017 12:37 PM, Andrea Bolognani wrote: > Depending on the architecture, requirements for ACPI and UEFI can > be different; more specifically, while on x86 UEFI requires ACPI, > on aarch64 it's the other way around. > > Enforce these requirements when building the QEMU command line, >

[libvirt] [PATCH 3/4] qemu: Enforce ACPI, UEFI requirements

2017-03-09 Thread Andrea Bolognani
Depending on the architecture, requirements for ACPI and UEFI can be different; more specifically, while on x86 UEFI requires ACPI, on aarch64 it's the other way around. Enforce these requirements when building the QEMU command line, and make the error message more accurate by mentioning that the