Re: [libvirt] [PATCH 3/4] qemu: Remove unnecessary virtio disk detach info.alias check

2017-11-08 Thread John Ferlan
On 10/20/2017 08:21 AM, Ján Tomko wrote: > On Fri, Oct 20, 2017 at 08:03:29AM -0400, John Ferlan wrote: >> Since qemuAssignDeviceDiskAlias checks whether the input info.alias >> is already present, no need to check here as well. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH 3/4] qemu: Remove unnecessary virtio disk detach info.alias check

2017-10-20 Thread John Ferlan
On 10/20/2017 08:21 AM, Ján Tomko wrote: > On Fri, Oct 20, 2017 at 08:03:29AM -0400, John Ferlan wrote: >> Since qemuAssignDeviceDiskAlias checks whether the input info.alias >> is already present, no need to check here as well. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH 3/4] qemu: Remove unnecessary virtio disk detach info.alias check

2017-10-20 Thread Ján Tomko
On Fri, Oct 20, 2017 at 08:03:29AM -0400, John Ferlan wrote: Since qemuAssignDeviceDiskAlias checks whether the input info.alias is already present, no need to check here as well. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 6 ++ 1 file changed, 2

[libvirt] [PATCH 3/4] qemu: Remove unnecessary virtio disk detach info.alias check

2017-10-20 Thread John Ferlan
Since qemuAssignDeviceDiskAlias checks whether the input info.alias is already present, no need to check here as well. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c