Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-23 Thread Daniel P. Berrange
On Thu, Feb 23, 2017 at 01:15:50PM +0100, Martin Kletzander wrote: > On Thu, Feb 23, 2017 at 10:46:14AM +, Daniel P. Berrange wrote: > > On Thu, Feb 23, 2017 at 11:38:40AM +0100, Martin Kletzander wrote: > > > On Thu, Feb 23, 2017 at 09:48:48AM +, Daniel P. Berrange wrote: > > > > On Wed, F

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-23 Thread Martin Kletzander
On Thu, Feb 23, 2017 at 10:46:14AM +, Daniel P. Berrange wrote: On Thu, Feb 23, 2017 at 11:38:40AM +0100, Martin Kletzander wrote: On Thu, Feb 23, 2017 at 09:48:48AM +, Daniel P. Berrange wrote: > On Wed, Feb 22, 2017 at 09:19:15PM +0100, Martin Kletzander wrote: > > On Wed, Feb 22, 2017

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-23 Thread Daniel P. Berrange
On Thu, Feb 23, 2017 at 11:38:40AM +0100, Martin Kletzander wrote: > On Thu, Feb 23, 2017 at 09:48:48AM +, Daniel P. Berrange wrote: > > On Wed, Feb 22, 2017 at 09:19:15PM +0100, Martin Kletzander wrote: > > > On Wed, Feb 22, 2017 at 02:44:01PM -0500, Laine Stump wrote: > > > > On 02/22/2017 12

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-23 Thread Martin Kletzander
On Thu, Feb 23, 2017 at 09:48:48AM +, Daniel P. Berrange wrote: On Wed, Feb 22, 2017 at 09:19:15PM +0100, Martin Kletzander wrote: On Wed, Feb 22, 2017 at 02:44:01PM -0500, Laine Stump wrote: > On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: > > One of the conditions in qemuDomainDeviceCal

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-23 Thread Daniel P. Berrange
On Wed, Feb 22, 2017 at 09:19:15PM +0100, Martin Kletzander wrote: > On Wed, Feb 22, 2017 at 02:44:01PM -0500, Laine Stump wrote: > > On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: > > > One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags > > > was missing a break that could result

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-23 Thread Daniel P. Berrange
On Wed, Feb 22, 2017 at 02:52:08PM -0600, Eric Blake wrote: > On 02/22/2017 11:52 AM, Daniel P. Berrange wrote: > > One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags > > was missing a break that could result it in falling through to > > an incorrect codepath. > > > > Signed-off-by:

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-23 Thread Daniel P. Berrange
On Wed, Feb 22, 2017 at 03:00:41PM -0600, Eric Blake wrote: > On 02/22/2017 01:44 PM, Laine Stump wrote: > > On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: > >> One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags > >> was missing a break that could result it in falling through to >

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-22 Thread Eric Blake
On 02/22/2017 01:44 PM, Laine Stump wrote: > On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: >> One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags >> was missing a break that could result it in falling through to >> an incorrect codepath. > > Actually that's not true. Every codepa

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-22 Thread Eric Blake
On 02/22/2017 11:52 AM, Daniel P. Berrange wrote: > One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags > was missing a break that could result it in falling through to > an incorrect codepath. > > Signed-off-by: Daniel P. Berrange > --- > src/qemu/qemu_domain_address.c | 1 + > 1

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-22 Thread Martin Kletzander
On Wed, Feb 22, 2017 at 02:44:01PM -0500, Laine Stump wrote: On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags was missing a break that could result it in falling through to an incorrect codepath. Actually that's not true. Every

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-22 Thread Laine Stump
On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags was missing a break that could result it in falling through to an incorrect codepath. Actually that's not true. Every codepath of the preceding case ends with a "return blah". T

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-22 Thread Andrea Bolognani
On Wed, 2017-02-22 at 17:52 +, Daniel P. Berrange wrote: > @@ -553,6 +553,7 @@ > qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDefPtr dev, >  return pciFlags; >  } >  } > +break; >   >  case VIR_DOMAIN_DEVICE_FS: >  /* the only type of file

[libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

2017-02-22 Thread Daniel P. Berrange
One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags was missing a break that could result it in falling through to an incorrect codepath. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_domain_address.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain_ad