Re: [libvirt] [PATCH 3/4] remote: forbid the --listen arg when systemd socket activation

2019-08-27 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:06:47PM +0200, Ján Tomko wrote: > On Fri, Aug 23, 2019 at 04:11:42PM +0100, Daniel P. Berrangé wrote: > > When using systemd socket activation the --listen arg has no > > effect. This is confusing to users upgrading from previous versions of > > libvirt as their config

Re: [libvirt] [PATCH 3/4] remote: forbid the --listen arg when systemd socket activation

2019-08-26 Thread Ján Tomko
On Fri, Aug 23, 2019 at 04:11:42PM +0100, Daniel P. Berrangé wrote: When using systemd socket activation the --listen arg has no effect. This is confusing to users upgrading from previous versions of libvirt as their config is silently ignored. Turn use of --listen into a fatal error when

[libvirt] [PATCH 3/4] remote: forbid the --listen arg when systemd socket activation

2019-08-23 Thread Daniel P . Berrangé
When using systemd socket activation the --listen arg has no effect. This is confusing to users upgrading from previous versions of libvirt as their config is silently ignored. Turn use of --listen into a fatal error when sockets are passed from systemd. This helps the admin discover the change