Re: [libvirt] [PATCH 3/4] security, apparmor: add (Set|Restore)ChardevLabel

2018-01-09 Thread Christian Ehrhardt
>> +char *in = NULL, *out = NULL; >> +int ret = -1; >> + >> +virSecurityLabelDefPtr secdef = virDomainDefGetSecurityLabelDef(def, >> +SECURITY_APPARMOR_NAME); >> +if (!secdef) >> +return 0; > > There shouldn't be empty line in

Re: [libvirt] [PATCH 3/4] security, apparmor: add (Set|Restore)ChardevLabel

2018-01-09 Thread Michal Privoznik
On 01/03/2018 06:00 PM, Christian Ehrhardt wrote: > Since 1b4f66e "security: introduce virSecurityManager > (Set|Restore)ChardevLabel" this is a public API of security manager. > > Implementing this in apparmor avoids miss any rules that should be > added for devices labeled via these calls. I be

[libvirt] [PATCH 3/4] security, apparmor: add (Set|Restore)ChardevLabel

2018-01-03 Thread Christian Ehrhardt
Since 1b4f66e "security: introduce virSecurityManager (Set|Restore)ChardevLabel" this is a public API of security manager. Implementing this in apparmor avoids miss any rules that should be added for devices labeled via these calls. Signed-off-by: Christian Ehrhardt --- src/security/security_ap