Re: [libvirt] [PATCH 3/4] storage_conf: Fix the scsi_host.name comparison

2014-10-06 Thread John Ferlan
On 10/03/2014 09:20 AM, Ján Tomko wrote: On 09/30/2014 11:35 PM, John Ferlan wrote: Since the 'scsi_host#' concept was introduced in commit id '9f781da6' it is possible to provide either name='host#' or name='scsi_host#' to define/name the scsi_host adapter source address. The concept being

Re: [libvirt] [PATCH 3/4] storage_conf: Fix the scsi_host.name comparison

2014-10-06 Thread Ján Tomko
On 10/06/2014 01:03 PM, John Ferlan wrote: On 10/03/2014 09:20 AM, Ján Tomko wrote: On 09/30/2014 11:35 PM, John Ferlan wrote: Since the 'scsi_host#' concept was introduced in commit id '9f781da6' it is possible to provide either name='host#' or name='scsi_host#' to define/name the

Re: [libvirt] [PATCH 3/4] storage_conf: Fix the scsi_host.name comparison

2014-10-06 Thread John Ferlan
On 10/06/2014 08:45 AM, Ján Tomko wrote: On 10/06/2014 01:03 PM, John Ferlan wrote: ...snip... static bool +matchSCSIAdapterName(const char *pool_name, + const char *def_name) +{ +/* Names can be either scsi_host# or just host#, where + * host# is the

Re: [libvirt] [PATCH 3/4] storage_conf: Fix the scsi_host.name comparison

2014-10-03 Thread Ján Tomko
On 09/30/2014 11:35 PM, John Ferlan wrote: Since the 'scsi_host#' concept was introduced in commit id '9f781da6' it is possible to provide either name='host#' or name='scsi_host#' to define/name the scsi_host adapter source address. The concept being that 'name#' is/was legacy and

[libvirt] [PATCH 3/4] storage_conf: Fix the scsi_host.name comparison

2014-09-30 Thread John Ferlan
Since the 'scsi_host#' concept was introduced in commit id '9f781da6' it is possible to provide either name='host#' or name='scsi_host#' to define/name the scsi_host adapter source address. The concept being that 'name#' is/was legacy and 'scsi_host#' is what's seen in the 'virsh nodedev-list