Re: [libvirt] [PATCH 3/4] util: Fix for NULL dereference

2018-11-17 Thread Radoslaw Biernacki
On Thu, 15 Nov 2018 at 12:23, Michal Privoznik wrote: > On 11/10/2018 01:56 PM, Radoslaw Biernacki wrote: > > The device xml parser code does not set "model" while parsing > > > > > > function='0x2'/> > > > > > > virDomainDefPtr def->nets[i]->model can be NULL while latter compares

Re: [libvirt] [PATCH 3/4] util: Fix for NULL dereference

2018-11-15 Thread Michal Privoznik
On 11/10/2018 01:56 PM, Radoslaw Biernacki wrote: > The device xml parser code does not set "model" while parsing > > > function='0x2'/> > > > virDomainDefPtr def->nets[i]->model can be NULL while latter compares strings > with > STREQ instead of STREQ_NULLABLE. > > Fixes:

[libvirt] [PATCH 3/4] util: Fix for NULL dereference

2018-11-10 Thread Radoslaw Biernacki
The device xml parser code does not set "model" while parsing virDomainDefPtr def->nets[i]->model can be NULL while latter compares strings with STREQ instead of STREQ_NULLABLE. Fixes: ac47e4a6225 (qemu: replace "def->nets[i]" with "net" and "def->sounds[i]" with "sound") Fixes: