Re: [libvirt] [PATCH 3/5] conf: Don't format cputune element when not needed

2012-12-20 Thread Martin Kletzander
On 12/18/2012 12:39 PM, Osier Yang wrote: > On 2012年12月18日 19:20, Martin Kletzander wrote: >> On 12/18/2012 04:01 AM, Osier Yang wrote: >>> On 2012年12月17日 23:17, Martin Kletzander wrote: Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that when editing an XML with cputune

Re: [libvirt] [PATCH 3/5] conf: Don't format cputune element when not needed

2012-12-18 Thread Osier Yang
On 2012年12月18日 19:20, Martin Kletzander wrote: On 12/18/2012 04:01 AM, Osier Yang wrote: On 2012年12月17日 23:17, Martin Kletzander wrote: Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that when editing an XML with cputune similar to this: Thanks for fixing this. ... 2

Re: [libvirt] [PATCH 3/5] conf: Don't format cputune element when not needed

2012-12-18 Thread Martin Kletzander
On 12/18/2012 04:01 AM, Osier Yang wrote: > On 2012年12月17日 23:17, Martin Kletzander wrote: >> Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that >> when editing an XML with cputune similar to this: > > Thanks for fixing this. > >> >> ... >>2 >> >> >> >> ... >>

Re: [libvirt] [PATCH 3/5] conf: Don't format cputune element when not needed

2012-12-17 Thread Osier Yang
On 2012年12月17日 23:17, Martin Kletzander wrote: Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that when editing an XML with cputune similar to this: Thanks for fixing this. ... 2 ... results in formatted XML that looks like this: ... 2 ... Tha

[libvirt] [PATCH 3/5] conf: Don't format cputune element when not needed

2012-12-17 Thread Martin Kletzander
Commit 60b176c3d0f0d5037acfa5e27c7753f657833a0b introduced a bug that when editing an XML with cputune similar to this: ... 2 ... results in formatted XML that looks like this: ... 2 ... That is caused by a condition depending on def->cputune.vcpupin being set rather than c