Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Richard Weinberger
Am 26.11.2014 um 05:51 schrieb Martin Kletzander: On Tue, Nov 25, 2014 at 04:19:48PM +0100, Richard Weinberger wrote: On Tue, Nov 25, 2014 at 9:21 AM, Cedric Bosdonnat cbosdon...@suse.com wrote: On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote: On Mon, Nov 24, 2014 at 09:54:44PM

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Cedric Bosdonnat
Hi Martin, On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote: Instead of papering over the issue in libvirt better ship a non-broken iproute2 in openSUSE 13.2. real fix: https://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=f1b66ff Oh, thank you for

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Richard Weinberger
Am 26.11.2014 um 09:25 schrieb Cedric Bosdonnat: Hi Martin, On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote: Instead of papering over the issue in libvirt better ship a non-broken iproute2 in openSUSE 13.2. real fix:

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Cedric Bosdonnat
On Wed, 2014-11-26 at 09:34 +0100, Richard Weinberger wrote: Am 26.11.2014 um 09:25 schrieb Cedric Bosdonnat: Hi Martin, On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote: Instead of papering over the issue in libvirt better ship a non-broken iproute2 in openSUSE 13.2.

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Richard Weinberger
Am 26.11.2014 um 10:16 schrieb Cedric Bosdonnat: On Wed, 2014-11-26 at 09:34 +0100, Richard Weinberger wrote: Am 26.11.2014 um 09:25 schrieb Cedric Bosdonnat: Hi Martin, On Wed, 2014-11-26 at 05:51 +0100, Martin Kletzander wrote: Instead of papering over the issue in libvirt better ship a

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Eric Blake
On 11/26/2014 02:25 AM, Richard Weinberger wrote: So I think we should keep that for those running the buggy 3.16. openSUSE has to fix their package and to serve a bugfix update, full stop. Thought that may not happen only to openSUSE... and that fix didn't harm at all. Yes, but fixing

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-26 Thread Richard Weinberger
Am 26.11.2014 um 14:23 schrieb Eric Blake: On 11/26/2014 02:25 AM, Richard Weinberger wrote: So I think we should keep that for those running the buggy 3.16. openSUSE has to fix their package and to serve a bugfix update, full stop. Thought that may not happen only to openSUSE... and that

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-25 Thread Cedric Bosdonnat
On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote: On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote: Due to a change (or bug?) in ip link implementation, the command 'ip link add vnet0...' is forced into 'ip link add name vnet0...' The changed command also

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-25 Thread Martin Kletzander
On Tue, Nov 25, 2014 at 09:21:10AM +0100, Cedric Bosdonnat wrote: On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote: On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote: Due to a change (or bug?) in ip link implementation, the command 'ip link add vnet0...' is forced

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-25 Thread Richard Weinberger
On Tue, Nov 25, 2014 at 9:21 AM, Cedric Bosdonnat cbosdon...@suse.com wrote: On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote: On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote: Due to a change (or bug?) in ip link implementation, the command 'ip link add vnet0...'

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-25 Thread Martin Kletzander
On Tue, Nov 25, 2014 at 04:19:48PM +0100, Richard Weinberger wrote: On Tue, Nov 25, 2014 at 9:21 AM, Cedric Bosdonnat cbosdon...@suse.com wrote: On Tue, 2014-11-25 at 08:42 +0100, Martin Kletzander wrote: On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote: Due to a change (or

[libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-24 Thread Cédric Bosdonnat
Due to a change (or bug?) in ip link implementation, the command 'ip link add vnet0...' is forced into 'ip link add name vnet0...' The changed command also works on older versions of iproute2, just the 'name' parameter has been made mandatory. --- src/util/virnetdevveth.c | 4 ++-- 1 file

Re: [libvirt] [PATCH 3/5] ip link needs 'name' in 3.16 to create the veth pair

2014-11-24 Thread Martin Kletzander
On Mon, Nov 24, 2014 at 09:54:44PM +0100, Cédric Bosdonnat wrote: Due to a change (or bug?) in ip link implementation, the command 'ip link add vnet0...' is forced into 'ip link add name vnet0...' The changed command also works on older versions of iproute2, just the 'name' parameter has