Re: [libvirt] [PATCH 3/5] libvirt/qemu - support persistent modification of devices.

2011-03-15 Thread KAMEZAWA Hiroyuki
On Wed, 16 Mar 2011 09:28:46 +0800 Hu Tao wrote: > > > > > + > > > > +static int qemuDomainModifyDevicePersistent(virDomainPtr dom, > > > > const char *xml, > > > > > > Indentation is not consistent. > > > > > ok. > > FYI, if you use vim as your edito

Re: [libvirt] [PATCH 3/5] libvirt/qemu - support persistent modification of devices.

2011-03-15 Thread Eric Blake
On 03/15/2011 07:28 PM, Hu Tao wrote: > + +static int qemuDomainModifyDevicePersistent(virDomainPtr dom, const char *xml, >>> >>> Indentation is not consistent. >>> >> ok. > > FYI, if you use vim as your editor, the following configuration

Re: [libvirt] [PATCH 3/5] libvirt/qemu - support persistent modification of devices.

2011-03-15 Thread Hu Tao
> > > + > > > +static int qemuDomainModifyDevicePersistent(virDomainPtr dom, > > > const char *xml, > > > > Indentation is not consistent. > > > ok. FYI, if you use vim as your editor, the following configuration can save you a lot of time: set autoind

Re: [libvirt] [PATCH 3/5] libvirt/qemu - support persistent modification of devices.

2011-03-15 Thread KAMEZAWA Hiroyuki
On Tue, 15 Mar 2011 15:55:51 -0600 Eric Blake wrote: > On 03/02/2011 06:11 PM, KAMEZAWA Hiroyuki wrote: > >>From f7a997e3cd58cfac81e131afdd20c3691267831d Mon Sep 17 00:00:00 2001 > > From: KAMEZAWA Hiroyuki > > Date: Thu, 3 Mar 2011 09:43:07 +0900 > > Subject: [PATCH 3/5] libivrt/qemu - support

Re: [libvirt] [PATCH 3/5] libvirt/qemu - support persistent modification of devices.

2011-03-15 Thread Eric Blake
On 03/02/2011 06:11 PM, KAMEZAWA Hiroyuki wrote: >>From f7a997e3cd58cfac81e131afdd20c3691267831d Mon Sep 17 00:00:00 2001 > From: KAMEZAWA Hiroyuki > Date: Thu, 3 Mar 2011 09:43:07 +0900 > Subject: [PATCH 3/5] libivrt/qemu - support persistent modification of > devices. > > Now, virsh attach-***

Re: [libvirt] [PATCH 3/5] libvirt/qemu - support persistent modification of devices.

2011-03-14 Thread KAMEZAWA Hiroyuki
On Mon, 14 Mar 2011 13:29:13 +0800 Wen Congyang wrote: > At 03/03/2011 09:11 AM, KAMEZAWA Hiroyuki Write: > >>From f7a997e3cd58cfac81e131afdd20c3691267831d Mon Sep 17 00:00:00 2001 > > From: KAMEZAWA Hiroyuki > > Date: Thu, 3 Mar 2011 09:43:07 +0900 > > Subject: [PATCH 3/5] libivrt/qemu - suppor

Re: [libvirt] [PATCH 3/5] libvirt/qemu - support persistent modification of devices.

2011-03-13 Thread Wen Congyang
At 03/03/2011 09:11 AM, KAMEZAWA Hiroyuki Write: >>From f7a997e3cd58cfac81e131afdd20c3691267831d Mon Sep 17 00:00:00 2001 > From: KAMEZAWA Hiroyuki > Date: Thu, 3 Mar 2011 09:43:07 +0900 > Subject: [PATCH 3/5] libivrt/qemu - support persistent modification of > devices. > > Now, virsh attach-***

[libvirt] [PATCH 3/5] libvirt/qemu - support persistent modification of devices.

2011-03-02 Thread KAMEZAWA Hiroyuki
>From f7a997e3cd58cfac81e131afdd20c3691267831d Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki Date: Thu, 3 Mar 2011 09:43:07 +0900 Subject: [PATCH 3/5] libivrt/qemu - support persistent modification of devices. Now, virsh attach-***/detach-*** has --persistent option and it can update XML defin