Re: [libvirt] [PATCH 3/5] remote: implement remote protocol for virConnectListAllDomains()

2012-05-22 Thread Peter Krempa
On 05/22/2012 01:30 AM, Eric Blake wrote: On 05/20/2012 09:56 AM, Peter Krempa wrote: This patch wires up the RPC protocol handlers for virConnectListAllDomains(). The RPC generator has no support for the way how virConnectListAllDomains() returns the results so the handler code had to be done

Re: [libvirt] [PATCH 3/5] remote: implement remote protocol for virConnectListAllDomains()

2012-05-22 Thread Eric Blake
On 05/22/2012 08:05 AM, Peter Krempa wrote: + +struct remote_connect_list_all_domains_ret { +remote_nonnull_domain domains; This is an unbounded array; we aren't using any of these anywhere else. I wonder if reusing REMOTE_DOMAIN_ID_LIST_MAX would be reasonable instead. Then again,

Re: [libvirt] [PATCH 3/5] remote: implement remote protocol for virConnectListAllDomains()

2012-05-21 Thread Eric Blake
On 05/20/2012 09:56 AM, Peter Krempa wrote: This patch wires up the RPC protocol handlers for virConnectListAllDomains(). The RPC generator has no support for the way how virConnectListAllDomains() returns the results so the handler code had to be done manually. The new api is handled by

[libvirt] [PATCH 3/5] remote: implement remote protocol for virConnectListAllDomains()

2012-05-20 Thread Peter Krempa
This patch wires up the RPC protocol handlers for virConnectListAllDomains(). The RPC generator has no support for the way how virConnectListAllDomains() returns the results so the handler code had to be done manually. The new api is handled by REMOTE_PROC_CONNECT_LIST_ALL_DOMAINS, with number