Re: [libvirt] [PATCH 3/5] virDomainNetDefParseXML: suppress generation of MAC when VIR_DOMAIN_PARSE_NO_GENERATE is set

2011-03-18 Thread Michal Prívozník
On 03/17/2011 06:07 PM, Daniel P. Berrange wrote: On Thu, Mar 17, 2011 at 12:55:50PM -0400, Laine Stump wrote: On 03/17/2011 10:38 AM, Michal Privoznik wrote: --- src/conf/domain_conf.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH 3/5] virDomainNetDefParseXML: suppress generation of MAC when VIR_DOMAIN_PARSE_NO_GENERATE is set

2011-03-18 Thread Daniel P. Berrange
On Fri, Mar 18, 2011 at 04:45:17PM +0100, Michal Prívozník wrote: On 03/17/2011 06:07 PM, Daniel P. Berrange wrote: On Thu, Mar 17, 2011 at 12:55:50PM -0400, Laine Stump wrote: On 03/17/2011 10:38 AM, Michal Privoznik wrote: --- src/conf/domain_conf.c | 11 --- 1 files changed,

Re: [libvirt] [PATCH 3/5] virDomainNetDefParseXML: suppress generation of MAC when VIR_DOMAIN_PARSE_NO_GENERATE is set

2011-03-18 Thread Eric Blake
On 03/18/2011 10:13 AM, Daniel P. Berrange wrote: I am not completely convinced this is what we want. If domain has exactly one NIC, device-detach semantic is clear. Or if we want to allow detaching interface by PCI address - MAC shouldn't be required, because it is redundant. You're

Re: [libvirt] [PATCH 3/5] virDomainNetDefParseXML: suppress generation of MAC when VIR_DOMAIN_PARSE_NO_GENERATE is set

2011-03-18 Thread Daniel P. Berrange
On Fri, Mar 18, 2011 at 10:28:34AM -0600, Eric Blake wrote: On 03/18/2011 10:13 AM, Daniel P. Berrange wrote: I am not completely convinced this is what we want. If domain has exactly one NIC, device-detach semantic is clear. Or if we want to allow detaching interface by PCI address - MAC

Re: [libvirt] [PATCH 3/5] virDomainNetDefParseXML: suppress generation of MAC when VIR_DOMAIN_PARSE_NO_GENERATE is set

2011-03-17 Thread Laine Stump
On 03/17/2011 10:38 AM, Michal Privoznik wrote: --- src/conf/domain_conf.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c2c7057..7f9c178 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

Re: [libvirt] [PATCH 3/5] virDomainNetDefParseXML: suppress generation of MAC when VIR_DOMAIN_PARSE_NO_GENERATE is set

2011-03-17 Thread Daniel P. Berrange
On Thu, Mar 17, 2011 at 12:55:50PM -0400, Laine Stump wrote: On 03/17/2011 10:38 AM, Michal Privoznik wrote: --- src/conf/domain_conf.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index