Re: [libvirt] [PATCH 3/5] virlog: Refactor virLogParseOutputs

2016-03-19 Thread Ján Tomko
On Wed, Mar 16, 2016 at 12:05:35PM +0100, Erik Skultety wrote: > The problem with the original virLogParseOutputs method was that the way it > parsed the input, walking the string char by char and using absolute jumps > depending on the virLogDestination type, was rather complicated to read. >

[libvirt] [PATCH 3/5] virlog: Refactor virLogParseOutputs

2016-03-16 Thread Erik Skultety
The problem with the original virLogParseOutputs method was that the way it parsed the input, walking the string char by char and using absolute jumps depending on the virLogDestination type, was rather complicated to read. This patch utilizes virStringSplit method twice, first time to filter out