Re: [libvirt] [PATCH 3/6] Fix data structure handling when controllers are attached.

2010-03-02 Thread Daniel Veillard
On Fri, Feb 26, 2010 at 02:09:16PM +0100, Wolfgang Mauerer wrote: > We must not delete the data part when the operation succeeds > because it is required later on. The correct pattern to handle > the parsed representation of the device information on success > is dev->data.controller = NULL; virDom

Re: [libvirt] [PATCH 3/6] Fix data structure handling when controllers are attached.

2010-03-01 Thread Daniel P. Berrange
On Fri, Feb 26, 2010 at 02:09:16PM +0100, Wolfgang Mauerer wrote: > We must not delete the data part when the operation succeeds > because it is required later on. The correct pattern to handle > the parsed representation of the device information on success > is dev->data.controller = NULL; virDom

[libvirt] [PATCH 3/6] Fix data structure handling when controllers are attached.

2010-02-26 Thread Wolfgang Mauerer
We must not delete the data part when the operation succeeds because it is required later on. The correct pattern to handle the parsed representation of the device information on success is dev->data.controller = NULL; virDomainDeviceDefFree(dev);, which leaves the structure pointed at by data in m