Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:08PM -0700, Eric Blake wrote: Create qemu monitor events as a distinct class to normal domain events, because they will be filtered differently. For ease of review, the logic for filtering by event name is saved for a later patch. * src/conf/domain_event.c

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Tue, Feb 11, 2014 at 03:08:46PM +, Daniel P. Berrange wrote: On Fri, Jan 31, 2014 at 07:12:08PM -0700, Eric Blake wrote: Create qemu monitor events as a distinct class to normal domain events, because they will be filtered differently. For ease of review, the logic for filtering by

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Fri, Jan 31, 2014 at 07:12:08PM -0700, Eric Blake wrote: Create qemu monitor events as a distinct class to normal domain events, because they will be filtered differently. For ease of review, the logic for filtering by event name is saved for a later patch. * src/conf/domain_event.c

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Eric Blake
On 02/11/2014 08:15 AM, Daniel P. Berrange wrote: --- src/conf/domain_event.c | 140 +++ src/conf/domain_event.h | 22 src/libvirt_private.syms | 2 + 3 files changed, 164 insertions(+) I think these APIs should be in

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Daniel P. Berrange
On Tue, Feb 11, 2014 at 08:26:50AM -0700, Eric Blake wrote: On 02/11/2014 08:15 AM, Daniel P. Berrange wrote: --- src/conf/domain_event.c | 140 +++ src/conf/domain_event.h | 22 src/libvirt_private.syms | 2 + 3 files

Re: [libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-02-11 Thread Eric Blake
On 02/11/2014 08:28 AM, Daniel P. Berrange wrote: On Tue, Feb 11, 2014 at 08:26:50AM -0700, Eric Blake wrote: On 02/11/2014 08:15 AM, Daniel P. Berrange wrote: --- src/conf/domain_event.c | 140 +++ src/conf/domain_event.h | 22

[libvirt] [PATCH 3/6] qemu: create object for qemu monitor events

2014-01-31 Thread Eric Blake
Create qemu monitor events as a distinct class to normal domain events, because they will be filtered differently. For ease of review, the logic for filtering by event name is saved for a later patch. * src/conf/domain_event.c (virDomainQemuMonitorEventClass): New class.