Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 01:21:26PM +0100, Pavel Hrdina wrote: > On Tue, Nov 21, 2017 at 12:09:54PM +, Daniel P. Berrange wrote: > > On Tue, Nov 21, 2017 at 01:02:05PM +0100, Peter Krempa wrote: > > > On Tue, Nov 21, 2017 at 11:48:20 +, Daniel Berrange wrote: > > > > On Tue, Nov 21, 2017 at

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Pavel Hrdina
On Tue, Nov 21, 2017 at 12:09:54PM +, Daniel P. Berrange wrote: > On Tue, Nov 21, 2017 at 01:02:05PM +0100, Peter Krempa wrote: > > On Tue, Nov 21, 2017 at 11:48:20 +, Daniel Berrange wrote: > > > On Tue, Nov 21, 2017 at 12:44:44PM +0100, Peter Krempa wrote: > > > > On Tue, Nov 21, 2017 at

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 01:02:05PM +0100, Peter Krempa wrote: > On Tue, Nov 21, 2017 at 11:48:20 +, Daniel Berrange wrote: > > On Tue, Nov 21, 2017 at 12:44:44PM +0100, Peter Krempa wrote: > > > On Tue, Nov 21, 2017 at 11:24:06 +, Daniel Berrange wrote: > > > > IOW, I don't think this patch

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 12:57:36PM +0100, Pavel Hrdina wrote: > On Tue, Nov 21, 2017 at 11:24:06AM +, Daniel P. Berrange wrote: > > On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote: > > > If there is no sound device configured for the guest we can disable the > > > audio output beca

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Peter Krempa
On Tue, Nov 21, 2017 at 11:48:20 +, Daniel Berrange wrote: > On Tue, Nov 21, 2017 at 12:44:44PM +0100, Peter Krempa wrote: > > On Tue, Nov 21, 2017 at 11:24:06 +, Daniel Berrange wrote: > > > IOW, I don't think this patch is desirable. > > > > We could allow hotplug only if qemu will allow

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Pavel Hrdina
On Tue, Nov 21, 2017 at 11:24:06AM +, Daniel P. Berrange wrote: > On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote: > > If there is no sound device configured for the guest we can disable the > > audio output because hot-plugging sound devices isn't supported. > > Are you sure abou

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 12:44:44PM +0100, Peter Krempa wrote: > On Tue, Nov 21, 2017 at 11:24:06 +, Daniel Berrange wrote: > > On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote: > > > If there is no sound device configured for the guest we can disable the > > > audio output because h

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Peter Krempa
On Tue, Nov 21, 2017 at 11:24:06 +, Daniel Berrange wrote: > On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote: > > If there is no sound device configured for the guest we can disable the > > audio output because hot-plugging sound devices isn't supported. > > Are you sure about tha

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote: > If there is no sound device configured for the guest we can disable the > audio output because hot-plugging sound devices isn't supported. Are you sure about that. While libvirt may not have wired up ability to hotplug sound devices,

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Pavel Hrdina
On Mon, Nov 20, 2017 at 05:55:10PM -0500, John Ferlan wrote: > > > On 11/14/2017 08:45 AM, Pavel Hrdina wrote: > > If there is no sound device configured for the guest we can disable the > > audio output because hot-plugging sound devices isn't supported. > > > > Signed-off-by: Pavel Hrdina > >

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-20 Thread John Ferlan
On 11/14/2017 08:45 AM, Pavel Hrdina wrote: > If there is no sound device configured for the guest we can disable the > audio output because hot-plugging sound devices isn't supported. > > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_command.c

[libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-14 Thread Pavel Hrdina
If there is no sound device configured for the guest we can disable the audio output because hot-plugging sound devices isn't supported. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 5 + tests/qemuxml2argvdata/qemuxml2argv-channel-spi