Re: [libvirt] [PATCH 3/7] node_device: detect CCW devices

2017-05-26 Thread John Ferlan
... >> >> ... >> >>> diff --git a/tests/nodedevschemadata/ccw_0_0_1-invalid.xml >>> b/tests/nodedevschemadata/ccw_0_0_1-invalid.xml >>> new file mode 100644 >>> index 0..d840555c0 >>> --- /dev/null >>> +++ b/tests/nodedevschemadata/ccw_0_0_1-invalid.xml >>> @@ -0,0 +1,10 @@ >>>

Re: [libvirt] [PATCH 3/7] node_device: detect CCW devices

2017-05-25 Thread Bjoern Walk
John Ferlan [2017-05-25, 03:05PM -0400]: One would hope they're in range, but since the rng had ranges should you check here similar to what virDomainDeviceCCWAddressIsValid does? It's fine this way since this is essentially reporting from udev which one can only assume (haha) would do validati

Re: [libvirt] [PATCH 3/7] node_device: detect CCW devices

2017-05-25 Thread John Ferlan
On 05/22/2017 02:38 AM, Bjoern Walk wrote: > Make CCW devices available to the node_device driver. The devices are > already seen by udev so let's implement necessary code for detecting > them properly. > > Topologically, CCW devices are similar to PCI devices, e.g.: > > +- ccw_0_0_1a2b >

[libvirt] [PATCH 3/7] node_device: detect CCW devices

2017-05-21 Thread Bjoern Walk
Make CCW devices available to the node_device driver. The devices are already seen by udev so let's implement necessary code for detecting them properly. Topologically, CCW devices are similar to PCI devices, e.g.: +- ccw_0_0_1a2b | +- scsi_host0 | +- s