Re: [libvirt] [PATCH 3/8] Use a separate buffer for subelements

2017-08-03 Thread Cole Robinson
On 08/03/2017 08:57 AM, Ján Tomko wrote: > On Wed, Aug 02, 2017 at 01:12:15PM -0400, Cole Robinson wrote: >> On 07/26/2017 09:29 AM, Ján Tomko wrote: >>> Convert virDomainSmartcardDefFormat to use a separate buffer >>> for possible subelements, to avoid the need for duplicated >>> formatting logic

Re: [libvirt] [PATCH 3/8] Use a separate buffer for subelements

2017-08-03 Thread Ján Tomko
On Wed, Aug 02, 2017 at 01:12:15PM -0400, Cole Robinson wrote: On 07/26/2017 09:29 AM, Ján Tomko wrote: Convert virDomainSmartcardDefFormat to use a separate buffer for possible subelements, to avoid the need for duplicated formatting logic in virDomainDeviceInfoNeedsFormat. --- src/conf/domain

Re: [libvirt] [PATCH 3/8] Use a separate buffer for subelements

2017-08-02 Thread Cole Robinson
On 07/26/2017 09:29 AM, Ján Tomko wrote: > Convert virDomainSmartcardDefFormat to use a separate buffer > for possible subelements, to avoid the need for duplicated > formatting logic in virDomainDeviceInfoNeedsFormat. > --- > src/conf/domain_conf.c | 39 +++ >

Re: [libvirt] [PATCH 3/8] Use a separate buffer for subelements

2017-08-01 Thread John Ferlan
On 07/26/2017 09:29 AM, Ján Tomko wrote: > Convert virDomainSmartcardDefFormat to use a separate buffer > for possible subelements, to avoid the need for duplicated > formatting logic in virDomainDeviceInfoNeedsFormat. > --- > src/conf/domain_conf.c | 39 +++ >

[libvirt] [PATCH 3/8] Use a separate buffer for subelements

2017-07-26 Thread Ján Tomko
Convert virDomainSmartcardDefFormat to use a separate buffer for possible subelements, to avoid the need for duplicated formatting logic in virDomainDeviceInfoNeedsFormat. --- src/conf/domain_conf.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) di