Re: [libvirt] [PATCH 3/9] target-i386: Call cpu_exec_init() on realize

2016-05-10 Thread Igor Mammedov
On Fri, 6 May 2016 15:11:26 -0300 Eduardo Habkost wrote: > QOM instance_init functions are not supposed to have any side-effects, > as new objects may be created at any moment for querying property > information (see qmp_device_list_properties()). > > Calling cpu_exec_init() also affects QEMU's

[libvirt] [PATCH 3/9] target-i386: Call cpu_exec_init() on realize

2016-05-06 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Calling cpu_exec_init() also affects QEMU's ability to handle errors during CPU creation, as some actions done by