Re: [libvirt] [PATCH 3 of 4] [LXC] Add XML parsing of container network interfaces

2008-06-26 Thread Dan Smith
DV> in that case the = NULL; are superfluous as they are local DV> variables, but i assume the compiler optimizes this easilly :-) Removed. DV> Looks fine +1 once the two leaks are plugged :-) Fixed. I'll go ahead and push these into CVS. Thanks! -- Dan Smith IBM Linux Technology Center Op

Re: [libvirt] [PATCH 3 of 4] [LXC] Add XML parsing of container network interfaces

2008-06-26 Thread Daniel Veillard
On Tue, Jun 24, 2008 at 08:51:35AM -0700, Dan Smith wrote: > Changes: > - Throw an error after parsing if nets were specified and NETNS support >is not present Fine by me [...] > +error_out: > +xmlFree(macaddr); > +macaddr = NULL; > +xmlFree(network); > +network = NULL; > +

[libvirt] [PATCH 3 of 4] [LXC] Add XML parsing of container network interfaces

2008-06-24 Thread Dan Smith
Changes: - Throw an error after parsing if nets were specified and NETNS support is not present diff -r 203dce381784 -r bb48967cf19e src/lxc_conf.c --- a/src/lxc_conf.cMon Jun 23 11:53:42 2008 -0700 +++ b/src/lxc_conf.cMon Jun 23 11:53:45 2008 -0700 @@ -69,6 +69,190 @@ __virRaiseE