Re: [libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-23 Thread Eric Blake
On 08/19/2011 03:58 PM, Eric Blake wrote: Adds an optional element todomainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. @@ -11044,6 +0,19 @@ virDomainSnapshotDefParseString(const char *xmlStr,

Re: [libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-23 Thread Eric Blake
On 08/19/2011 03:58 PM, Eric Blake wrote: Adds an optional element todomainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. Another couple of problems. +static int +disksorter(const void *a, const void *b)

Re: [libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-22 Thread Eric Blake
On 08/19/2011 07:29 PM, Eric Blake wrote: On 08/19/2011 03:58 PM, Eric Blake wrote: Adds an optional element todomainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. One more thing to squash in - make the

[libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-19 Thread Eric Blake
Adds an optional element to domainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. domainsnapshot ... disks disk name='vda' snapshot='no'/ disk name='vdb' snapshot='internal'/ disk name='vdc'

Re: [libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-19 Thread Eric Blake
On 08/19/2011 03:58 PM, Eric Blake wrote: Adds an optional element todomainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. +/* Double check requested disks. */ +for (i = 0; i def-ndisks; i++) { +