Re: [libvirt] [PATCH 34/41] remote: change generated methods to not directly access connection

2019-07-29 Thread Andrea Bolognani
On Mon, 2019-07-29 at 14:33 +0100, Daniel P. Berrangé wrote: > On Sun, Jul 28, 2019 at 07:50:28PM +0200, Andrea Bolognani wrote: > > On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > > > +++ b/src/rpc/gendispatch.pl > > > @@ -581,11 +599,11 @@ elsif ($mode eq "server") { > > >

Re: [libvirt] [PATCH 34/41] remote: change generated methods to not directly access connection

2019-07-29 Thread Daniel P . Berrangé
On Sun, Jul 28, 2019 at 07:50:28PM +0200, Andrea Bolognani wrote: > On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > > +++ b/src/remote/remote_daemon_dispatch.c > > @@ -2013,6 +2134,7 @@ remoteDispatchConnectClose(virNetServerPtr server > > ATTRIBUTE_UNUSED, > > } > > > > > > +

Re: [libvirt] [PATCH 34/41] remote: change generated methods to not directly access connection

2019-07-28 Thread Andrea Bolognani
On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > +++ b/src/remote/remote_daemon_dispatch.c > @@ -2013,6 +2134,7 @@ remoteDispatchConnectClose(virNetServerPtr server > ATTRIBUTE_UNUSED, > } > > > + > static int > remoteDispatchDomainGetSchedulerType(virNetServerPtr server

[libvirt] [PATCH 34/41] remote: change generated methods to not directly access connection

2019-07-23 Thread Daniel P . Berrangé
The driver dispatch methods access the priv->conn variables directly. In future we want to dynamically open the connections for the secondary driver. Thus we want the methods to call a method to get the connection handle instead of assuming the private variable is non-NULL. Signed-off-by: Daniel