Re: [libvirt] [PATCH 35/41] remote: change hand written methods to not directly access connection

2019-07-29 Thread Andrea Bolognani
On Mon, 2019-07-29 at 14:36 +0100, Daniel P. Berrangé wrote: > On Sun, Jul 28, 2019 at 08:19:40PM +0200, Andrea Bolognani wrote: > > On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > > [...] > > > +++ b/src/remote/remote_daemon_dispatch.c > > > @@ -4210,14 +4128,13 @@ > > >

Re: [libvirt] [PATCH 35/41] remote: change hand written methods to not directly access connection

2019-07-29 Thread Daniel P . Berrangé
On Sun, Jul 28, 2019 at 08:19:40PM +0200, Andrea Bolognani wrote: > On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > [...] > > +++ b/src/remote/remote_daemon_dispatch.c > > @@ -4210,14 +4128,13 @@ > > remoteDispatchConnectDomainEventRegister(virNetServerPtr server > >

Re: [libvirt] [PATCH 35/41] remote: change hand written methods to not directly access connection

2019-07-28 Thread Andrea Bolognani
On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: [...] > +++ b/src/remote/remote_daemon_dispatch.c > @@ -4210,14 +4128,13 @@ > remoteDispatchConnectDomainEventRegister(virNetServerPtr server > ATTRIBUTE_UNUSED > daemonClientEventCallbackPtr ref; > struct daemonClientPrivate

[libvirt] [PATCH 35/41] remote: change hand written methods to not directly access connection

2019-07-23 Thread Daniel P . Berrangé
The driver dispatch methods access the priv->conn variables directly. In future we want to dynamically open the connections for the secondary driver. Thus we want the methods to call a method to get the connection handle instead of assuming the private variable is non-NULL. Signed-off-by: Daniel