Re: [libvirt] [PATCH 37/41] remote: handle autoprobing of driver within virtproxyd

2019-07-29 Thread Daniel P . Berrangé
On Mon, Jul 29, 2019 at 12:25:08PM +0200, Andrea Bolognani wrote: > On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > [...] > > +++ b/src/remote/remote_daemon_dispatch.c > > +static int > > +remoteDispatchProbeURI(bool readonly, char **probeduri) > > Once again, there should be one ar

Re: [libvirt] [PATCH 37/41] remote: handle autoprobing of driver within virtproxyd

2019-07-29 Thread Andrea Bolognani
On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: [...] > +++ b/src/remote/remote_daemon_dispatch.c > +static int > +remoteDispatchProbeURI(bool readonly, char **probeduri) Once again, there should be one argument per line and a personal preference I'd rather have readonly as the last o

[libvirt] [PATCH 37/41] remote: handle autoprobing of driver within virtproxyd

2019-07-23 Thread Daniel P . Berrangé
The virtproxyd daemon is merely responsible for forwarding RPC calls to one of the other per-driver daemons. As such, it does not have any drivers loaded and so regular auto-probing logic will not work. We need it to be able to handle NULL URIs though, so must implement some kind of alternative pro