Re: [libvirt] [PATCH 38/38] qemu: domain: Add support for TLS for NBD with default TLS env

2018-05-31 Thread Peter Krempa
On Thu, May 31, 2018 at 07:34:14 -0400, John Ferlan wrote: > [...] > > >>> +qemuProcessPrepareStorageSourceTlsNbd(virStorageSourcePtr src, > >>> + virQEMUDriverConfigPtr cfg, > >>> + virQEMUCapsPtr qemuCaps) > >>> +{ > >>> +

Re: [libvirt] [PATCH 38/38] qemu: domain: Add support for TLS for NBD with default TLS env

2018-05-31 Thread John Ferlan
[...] >>> +qemuProcessPrepareStorageSourceTlsNbd(virStorageSourcePtr src, >>> + virQEMUDriverConfigPtr cfg, >>> + virQEMUCapsPtr qemuCaps) >>> +{ >>> +/* XXX: for NBD we don't have the qemu.conf knobs for private TLS env

Re: [libvirt] [PATCH 38/38] qemu: domain: Add support for TLS for NBD with default TLS env

2018-05-30 Thread Peter Krempa
On Wed, May 30, 2018 at 18:55:34 -0400, John Ferlan wrote: > > > On 05/30/2018 08:41 AM, Peter Krempa wrote: > > Use the default TLS env if TLS is required for NBD. The rest of the > > implementation is rather simple since all pieces were in place. > > > > Note that separate configuration knobs

Re: [libvirt] [PATCH 38/38] qemu: domain: Add support for TLS for NBD with default TLS env

2018-05-30 Thread John Ferlan
On 05/30/2018 08:41 AM, Peter Krempa wrote: > Use the default TLS env if TLS is required for NBD. The rest of the > implementation is rather simple since all pieces were in place. > > Note that separate configuration knobs in qemu.conf can be added later > if it's desired to configure them. >

Re: [libvirt] [PATCH 38/38] qemu: domain: Add support for TLS for NBD with default TLS env

2018-05-30 Thread Ján Tomko
On Wed, May 30, 2018 at 02:41:34PM +0200, Peter Krempa wrote: Use the default TLS env if TLS is required for NBD. The rest of the implementation is rather simple since all pieces were in place. Note that separate configuration knobs in qemu.conf can be added later if it's desired to configure th

[libvirt] [PATCH 38/38] qemu: domain: Add support for TLS for NBD with default TLS env

2018-05-30 Thread Peter Krempa
Use the default TLS env if TLS is required for NBD. The rest of the implementation is rather simple since all pieces were in place. Note that separate configuration knobs in qemu.conf can be added later if it's desired to configure them. Signed-off-by: Peter Krempa --- docs/schemas/domaincommon