Re: [libvirt] [PATCH 4/4] Add string labels to all VIR_ENUM_IMPL calls

2019-04-11 Thread Cole Robinson
On 4/11/19 6:58 AM, Daniel P. Berrangé wrote: > On Mon, Apr 08, 2019 at 11:48:19AM -0400, Cole Robinson wrote: >> Add string labels to all VIR_ENUM_IMPL calls, which will be used >> to eventually raise errors from virEnum*String functions. >> >> I roughly tried to follow these rules: >> >> 1) If it

Re: [libvirt] [PATCH 4/4] Add string labels to all VIR_ENUM_IMPL calls

2019-04-11 Thread Daniel P . Berrangé
On Mon, Apr 08, 2019 at 11:48:19AM -0400, Cole Robinson wrote: > Add string labels to all VIR_ENUM_IMPL calls, which will be used > to eventually raise errors from virEnum*String functions. > > I roughly tried to follow these rules: > > 1) If it's an internal only enum, try to uniquely describe i

[libvirt] [PATCH 4/4] Add string labels to all VIR_ENUM_IMPL calls

2019-04-08 Thread Cole Robinson
Add string labels to all VIR_ENUM_IMPL calls, which will be used to eventually raise errors from virEnum*String functions. I roughly tried to follow these rules: 1) If it's an internal only enum, try to uniquely describe it 2) If it's for user XML values, make the label match the XML value nam