Re: [libvirt] [PATCH 4/4] Fix symbol exports & remove duplicated libvirt_util.la linkage

2010-10-19 Thread Daniel Veillard
On Thu, Oct 14, 2010 at 03:45:01PM +0100, Daniel P. Berrange wrote: > On Thu, Oct 14, 2010 at 04:22:29PM +0200, Daniel Veillard wrote: > > On Tue, Oct 12, 2010 at 06:32:18PM +0100, Daniel P. Berrange wrote: > > > From: Miloslav Trmač > > > > > > The libvirt_util.la library was mistakenly linked i

Re: [libvirt] [PATCH 4/4] Fix symbol exports & remove duplicated libvirt_util.la linkage

2010-10-14 Thread Daniel P. Berrange
On Thu, Oct 14, 2010 at 04:22:29PM +0200, Daniel Veillard wrote: > On Tue, Oct 12, 2010 at 06:32:18PM +0100, Daniel P. Berrange wrote: > > From: Miloslav Trmač > > > > The libvirt_util.la library was mistakenly linked into libvirtd > > directly. Since libvirt_util.la is already linked to libvirt.

Re: [libvirt] [PATCH 4/4] Fix symbol exports & remove duplicated libvirt_util.la linkage

2010-10-14 Thread Daniel Veillard
On Tue, Oct 12, 2010 at 06:32:18PM +0100, Daniel P. Berrange wrote: > From: Miloslav Trmač > > The libvirt_util.la library was mistakenly linked into libvirtd > directly. Since libvirt_util.la is already linked to libvirt.so, > this resulted in libvirtd getting two copies of the code and > more c

Re: [libvirt] [PATCH 4/4] Fix symbol exports & remove duplicated libvirt_util.la linkage

2010-10-12 Thread Eric Blake
On 10/12/2010 11:32 AM, Daniel P. Berrange wrote: @@ -708,6 +735,18 @@ virFileFindMountPoint; virFileWaitForDevices; virFileMatchesNameSuffix; virArgvToString; +virStrcpy; +virStrncpy; +virBuildPathInternal; +virFileStripSuffix; +virFileOperation; +virFork; +virRandom; +virRandomInitialize;

[libvirt] [PATCH 4/4] Fix symbol exports & remove duplicated libvirt_util.la linkage

2010-10-12 Thread Daniel P. Berrange
From: Miloslav Trmač The libvirt_util.la library was mistakenly linked into libvirtd directly. Since libvirt_util.la is already linked to libvirt.so, this resulted in libvirtd getting two copies of the code and more critically 2 copies of static global variables. Testing in turn exposed a issue