Re: [libvirt] [PATCH 4/4] Replace daemon-conf test script with a proper test case

2012-04-10 Thread Daniel P. Berrange
On Fri, Apr 06, 2012 at 11:05:02AM -0600, Eric Blake wrote: > On 04/04/2012 08:07 AM, Daniel P. Berrange wrote: > > + > > +//VIR_DEBUG("New config [%s]", newdata); > > Did you mean to leave this commented? Yes, it makes the debug output far too verbose. Daniel -- |: http://berrange.com

Re: [libvirt] [PATCH 4/4] Replace daemon-conf test script with a proper test case

2012-04-06 Thread Eric Blake
On 04/04/2012 08:07 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The daemon-conf test script continues to be very fragile to > changes in libvirt. It currently fails 1 time in 3/4 due > to race conditions in startup/shutdown of the test script. > > Replace it with a proper test

[libvirt] [PATCH 4/4] Replace daemon-conf test script with a proper test case

2012-04-04 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The daemon-conf test script continues to be very fragile to changes in libvirt. It currently fails 1 time in 3/4 due to race conditions in startup/shutdown of the test script. Replace it with a proper test case tailored to the code being tested * tests/Makefile.am: Re