Re: [libvirt] [PATCH 4/4] lxc: store tty pid

2008-05-31 Thread Daniel Veillard
On Fri, May 30, 2008 at 04:31:14PM -0700, Dave Leskovec wrote: > Daniel Veillard wrote: > > On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote: > ... > > > > Hum, I'm surprized the PID file is removed only in lxcDomainUndefine. > > The PID file need to be re-created each time the doma

Re: [libvirt] [PATCH 4/4] lxc: store tty pid

2008-05-30 Thread Dave Leskovec
Daniel Veillard wrote: > On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote: ... > > Hum, I'm surprized the PID file is removed only in lxcDomainUndefine. > The PID file need to be re-created each time the domain is started. But > a domain could be started and stopped many time while

Re: [libvirt] [PATCH 4/4] lxc: store tty pid

2008-05-30 Thread Daniel P. Berrange
On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote: > er, this time with the patch > > Dave Leskovec wrote: > > This patch will use a file in the lxc configuration directory to store the > > tty > > forwarding process pid. The pid is stored after the process is fork()'d. > > It'

Re: [libvirt] [PATCH 4/4] lxc: store tty pid

2008-05-30 Thread Jim Meyering
Hi Dave, All four of your patches look good. I've included a few comments on the fourth below. Dave Leskovec <[EMAIL PROTECTED]> wrote: > Index: b/src/lxc_conf.h > === ... > +int lxcStoreTtyPid(lxc_driver_t *driver, lxc_vm_t *vm); >

Re: [libvirt] [PATCH 4/4] lxc: store tty pid

2008-05-29 Thread Daniel Veillard
On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote: > er, this time with the patch > > Dave Leskovec wrote: > > This patch will use a file in the lxc configuration directory to store the > > tty > > forwarding process pid. The pid is stored after the process is fork()'d. > > It'

Re: [libvirt] [PATCH 4/4] lxc: store tty pid

2008-05-29 Thread Dave Leskovec
er, this time with the patch Dave Leskovec wrote: > This patch will use a file in the lxc configuration directory to store the tty > forwarding process pid. The pid is stored after the process is fork()'d. > It's > loaded during startup when the config for a running container is loaded. Th

[libvirt] [PATCH 4/4] lxc: store tty pid

2008-05-29 Thread Dave Leskovec
This patch will use a file in the lxc configuration directory to store the tty forwarding process pid. The pid is stored after the process is fork()'d. It's loaded during startup when the config for a running container is loaded. The file is deleted when the domain is undefined. This should avo