On Fri, May 30, 2008 at 04:31:14PM -0700, Dave Leskovec wrote:
> Daniel Veillard wrote:
> > On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote:
> ...
> >
> > Hum, I'm surprized the PID file is removed only in lxcDomainUndefine.
> > The PID file need to be re-created each time the doma
Daniel Veillard wrote:
> On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote:
...
>
> Hum, I'm surprized the PID file is removed only in lxcDomainUndefine.
> The PID file need to be re-created each time the domain is started. But
> a domain could be started and stopped many time while
On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote:
> er, this time with the patch
>
> Dave Leskovec wrote:
> > This patch will use a file in the lxc configuration directory to store the
> > tty
> > forwarding process pid. The pid is stored after the process is fork()'d.
> > It'
Hi Dave,
All four of your patches look good.
I've included a few comments on the fourth below.
Dave Leskovec <[EMAIL PROTECTED]> wrote:
> Index: b/src/lxc_conf.h
> ===
...
> +int lxcStoreTtyPid(lxc_driver_t *driver, lxc_vm_t *vm);
>
On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote:
> er, this time with the patch
>
> Dave Leskovec wrote:
> > This patch will use a file in the lxc configuration directory to store the
> > tty
> > forwarding process pid. The pid is stored after the process is fork()'d.
> > It'
er, this time with the patch
Dave Leskovec wrote:
> This patch will use a file in the lxc configuration directory to store the tty
> forwarding process pid. The pid is stored after the process is fork()'d.
> It's
> loaded during startup when the config for a running container is loaded. Th
This patch will use a file in the lxc configuration directory to store the tty
forwarding process pid. The pid is stored after the process is fork()'d. It's
loaded during startup when the config for a running container is loaded. The
file is deleted when the domain is undefined. This should avo
