[libvirt] [PATCH 4/4] python: fix fd leak in generator.py

2013-02-28 Thread Guannan Ren
--- python/generator.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/generator.py b/python/generator.py index 7ccd471..4b62f83 100755 --- a/python/generator.py +++ b/python/generator.py @@ -771,6 +771,7 @@ def buildStubs(module, stubs_buiding_debug = False, xml_parsing_debug =

Re: [libvirt] [PATCH 4/4] python: fix fd leak in generator.py

2013-02-28 Thread Eric Blake
On 02/28/2013 03:03 AM, Guannan Ren wrote: --- python/generator.py | 3 +++ 1 file changed, 3 insertions(+) At first, I was worried that this is a leak in the generated code. But it looks like it is only a leak in the generator, and that the generated code is safe. So it's not an essential

Re: [libvirt] [PATCH 4/4] python: fix fd leak in generator.py

2013-02-28 Thread Guannan Ren
On 03/01/2013 06:26 AM, Eric Blake wrote: On 02/28/2013 03:03 AM, Guannan Ren wrote: --- python/generator.py | 3 +++ 1 file changed, 3 insertions(+) At first, I was worried that this is a leak in the generated code. But it looks like it is only a leak in the generator, and that the