Re: [libvirt] [PATCH 4/4] qemu: Fix qemuProcessInitCpuAffinity()

2019-06-04 Thread Andrea Bolognani
On Tue, 2019-06-04 at 07:03 -0400, John Ferlan wrote: > On 5/31/19 11:22 AM, Andrea Bolognani wrote: > > @@ -2489,11 +2489,16 @@ qemuProcessInitCpuAffinity(virDomainObjPtr vm) > > if (virDomainNumaGetNodeCount(vm->def->numa) <= 1 && > > virDomainNumatuneGetMode(vm->def->numa, -1,

Re: [libvirt] [PATCH 4/4] qemu: Fix qemuProcessInitCpuAffinity()

2019-06-04 Thread John Ferlan
On 5/31/19 11:22 AM, Andrea Bolognani wrote: > Commit f136b83139c6 made some changes in the way we set CPU > affinity for QEMU processes, and while doing so unfortunately > also introduced a logic bug in that it tried to use a NUMA node > map where a CPU map was expected. > > Because of that,

Re: [libvirt] [PATCH 4/4] qemu: Fix qemuProcessInitCpuAffinity()

2019-06-03 Thread Andrea Bolognani
On Fri, 2019-05-31 at 17:22 +0200, Andrea Bolognani wrote: > Commit f136b83139c6 made some changes in the way we set CPU > affinity for QEMU processes, and while doing so unfortunately > also introduced a logic bug in that it tried to use a NUMA node > map where a CPU map was expected.

Re: [libvirt] [PATCH 4/4] qemu: Fix qemuProcessInitCpuAffinity()

2019-06-03 Thread Ján Tomko
On Fri, May 31, 2019 at 05:22:02PM +0200, Andrea Bolognani wrote: Commit f136b83139c6 made some changes in the way we set CPU affinity for QEMU processes, and while doing so unfortunately also introduced a logic bug in that it tried to use a NUMA node map where a CPU map was expected. Because

[libvirt] [PATCH 4/4] qemu: Fix qemuProcessInitCpuAffinity()

2019-05-31 Thread Andrea Bolognani
Commit f136b83139c6 made some changes in the way we set CPU affinity for QEMU processes, and while doing so unfortunately also introduced a logic bug in that it tried to use a NUMA node map where a CPU map was expected. Because of that, guests using would suddenly fail to start: # virsh start