Re: [libvirt] [PATCH 4/4] qemu: Move shared disk entry adding and unpriv_sgio seting

2013-02-11 Thread Osier Yang
On 2013年02月11日 18:55, Daniel P. Berrange wrote: On Fri, Feb 08, 2013 at 09:08:02PM +0800, Osier Yang wrote: The disk def could be free'ed by qemuDomainChangeEjectableMedia for cdrom or floppy disk. This moves the adding and setting before the attaching takes place. And for cdrom floppy disk, if

Re: [libvirt] [PATCH 4/4] qemu: Move shared disk entry adding and unpriv_sgio seting

2013-02-11 Thread Daniel P. Berrange
On Fri, Feb 08, 2013 at 09:08:02PM +0800, Osier Yang wrote: > The disk def could be free'ed by qemuDomainChangeEjectableMedia > for cdrom or floppy disk. This moves the adding and setting before > the attaching takes place. And for cdrom floppy disk, if the > change is ejecting, removing the existe

Re: [libvirt] [PATCH 4/4] qemu: Move shared disk entry adding and unpriv_sgio seting

2013-02-08 Thread John Ferlan
On 02/08/2013 08:08 AM, Osier Yang wrote: > The disk def could be free'ed by qemuDomainChangeEjectableMedia > for cdrom or floppy disk. This moves the adding and setting before > the attaching takes place. And for cdrom floppy disk, if the > change is ejecting, removing the existed hash entry for i

[libvirt] [PATCH 4/4] qemu: Move shared disk entry adding and unpriv_sgio seting

2013-02-08 Thread Osier Yang
The disk def could be free'ed by qemuDomainChangeEjectableMedia for cdrom or floppy disk. This moves the adding and setting before the attaching takes place. And for cdrom floppy disk, if the change is ejecting, removing the existed hash entry for it. --- src/qemu/qemu_driver.c | 23 +++